move object to hidden layer, called "hide layer" in UndoHist

This is NOT a support forum. You are welcome to discuss software issues here, but all issues should be reported on Launchpad if you want them fixed.
User avatar
brynn
Posts: 10309
Joined: Wed Sep 26, 2007 4:34 pm
Location: western USA
Contact:

move object to hidden layer, called "hide layer" in UndoHist

Postby brynn » Fri Jul 08, 2011 6:57 pm

Hi Friends,
Once again, as I have many, many times before, I'm happily enjoying Inkscape while pretending/practicing to be an artist! As always, thanks to developers Image

While Undoing a few steps back, I became confused, and opened the Undo History to make sure I was going back to the right place. It was then that I noticed that moving an object to a hidden layer is listed in the Undo History as "Hide layer". (And moving an object out of a hidden layer is called "Unhide layer".) That doesn't seem right to me, as I expected it to say "Lower to previous layer" (or "Raise to next layer").

I know that in Inkscape, layers are really special Groups. But even thinking in terms of groups, I can't make the leap from "add object to hidden group" to "hide group". So I'm thinking this must be a bug?

I made a bug report about several issues with the Undo History, way back in 2008 (https://bugs.launchpad.net/inkscape/+bug/251205). So IF this is a bug, should I add a comment to my original report, or make a new one?

Or is there some logical reason why moving an object to a hidden layer is called "hide layer"??

Thank you very much :D

~suv
Posts: 2272
Joined: Sun May 10, 2009 2:07 am

Re: move object to hidden layer, called "hide layer" in Undo

Postby ~suv » Sat Jul 09, 2011 3:59 pm

brynn wrote: It was then that I noticed that moving an object to a hidden layer is listed in the Undo History as "Hide layer". (And moving an object out of a hidden layer is called "Unhide layer".) That doesn't seem right to me, as I expected it to say "Lower to previous layer" (or "Raise to next layer").


Reproduced with Inkscape 0.46, 0.47, 0.48.0 and 0.48.1.

No longer happens in the current development branch, and in the upcoming 0.48.2: the 'Undo History' correctly records moving a selection (up or down) to a hidden layer (and back). Like in Inkscape 0.47 (or not - I got inconsistent results) [1], the object moved to the hidden layer will pick up the 'hidden' status (style attribute 'display:none') from that layer when moved back to a visible layer:
Image


Edit:
  • [1] not sure what detail did trigger it in some of my tests.
  • AFAICT by testing older development builds, the change was introduced with the fix for (otherwise not related) bug #249035
  • for the retained 'hidden' attribute: similar to what is described in bug #322124 “Layer style definitions are copied to shapes” the style attribute 'display:none' of the parent group (layers are groups) is inherited by the object when moved outside the group/to or through another layer.
Edit 2:

User avatar
brynn
Posts: 10309
Joined: Wed Sep 26, 2007 4:34 pm
Location: western USA
Contact:

Re: move object to hidden layer, called "hide layer" in Undo

Postby brynn » Sun Jul 10, 2011 2:26 am

Oh wow!
So it seems that you found more issues related this, than just the wrong words in Undo History. I try but don't understand them, the attributes and other bugs (in a meaningful way) but I'm glad my post/report was of some constructive use :)

Reproduced with Inkscape 0.46, 0.47, 0.48.0 and 0.48.1.

and
AFAICT by testing older development builds, ....

Out of sheer curiousity, how many versions and builds of Inkscape do you have, and use for development and troubleshooting?

Thanks ~suv :D


Return to “Discuss Software Issues”